Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: beforeSend / fingerprinting #70

Merged
merged 25 commits into from
Apr 21, 2023
Merged

feat: beforeSend / fingerprinting #70

merged 25 commits into from
Apr 21, 2023

Conversation

buenaflor
Copy link
Contributor

Ref: #47 & #65

This adds a beforeSend hook to manipulate event - at the same time it also adds the capability to add fingerprints.

@buenaflor buenaflor self-assigned this Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6850b12

@buenaflor buenaflor requested a review from marandaneto April 6, 2023 17:30
@marandaneto
Copy link
Contributor

I'd like to see some unit tests with all the other changes.

@buenaflor buenaflor requested a review from marandaneto April 17, 2023 10:07
@buenaflor
Copy link
Contributor Author

@marandaneto bump, you think it's good2go?

@buenaflor buenaflor requested a review from marandaneto April 19, 2023 12:35
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a last comment but decide on the best of your judgment, it's just an L.
LGTM.

@buenaflor buenaflor merged commit 8d8cd4e into main Apr 21, 2023
@buenaflor buenaflor deleted the feat/beforeSend branch April 21, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants