fix: Fix migr8 crashing on windows due to Unix path delimiters #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/fix-path-on-windows
branch
from
5778197
to
2599a7a
Compare
mydea
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a dynamic
await import('./path/to/transformer.js')to import our individual transformers easily. This doesn't work under Windows because the import path needs to be a file URL as reported in #38.Now, to test migr8 under windows, I wanted to add a
windows-latestbased runner. Which worked and I got rid of the initial error. However, I'm now running into a terminal/shell error (bombshell-dev/clack#192) which, according to the issue this only happens in Git Bash-powered terminals. I tried setting a diffrentshell, removing the git versions ofbash.exeandsh.exebut could not get around this error.I think the commit history of this branch speaks for itself 🥲
So what we know is that the initial error is fixed with this PR. What I don't know yet is if migr8 will work under windows 🙃
Let's try this, cut a release and ask for feedback.