fix: Update crashpad and suppress C5105 #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning was newly introduced in VS 16.8, but breaks with the Windows SDKs own `winbase.h` header. We will just suppress it for now.
jan-auer
approved these changes
Nov 20, 2020
flub
approved these changes
Nov 20, 2020
flub
approved these changes
Nov 20, 2020
| sentry_pathchar_t *filename | ||
| = (sentry_pathchar_t *)sentry__path_filename(dir_path); | ||
| if (filename > dir_path->path) { | ||
| *(filename - 1) = L'\0'; |
There was a problem hiding this comment.
Hahaha, I constantly facepalming why we have to write all this horrible code over and over again just because C does not have a sufficiently good std lib, such as Rusts Path(Buf) / &str/String 🤦♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning was newly introduced in VS 16.8, but breaks with the
Windows SDKs own
winbase.hheader. We will just suppress it for now.