Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: feat(tracing): add in actual types very wip probably 30% done #646

Closed
wants to merge 1 commit into from

Conversation

relaxolotl
Copy link
Contributor

!!!!! WIP !!!!!!!

wip             wip  wip  wipwipwip 
wip             wip  wip  wip    wip
wip             wip  wip  wip    wip
wip     wip     wip  wip  wipwipwip 
   wip  wip  wip     wip  wip       
   wipwipwipwip      wip  wip         

by the way did i mention that this was a WORK IN PROGRESS PR, that means that msot of this work is probably not remotely done, and the list below is a summary of what is done

about 30% of this is done.

  • copy over types introduced ages ago for spans, transactions, their contexts
    • stuff ref to transaction into span
  • update signatures to use new types
  • implement reference counting for types
  • transaction context: port constructor and setters
  • transactions: port start and finish
  • spans: port start child and finish
  • odds and ends
  • update tests

super bonus changes

  • converter function from status enum to their respective string
  • change finish child's signature
  • build an idea of how concurrency is even going to work here

@Swatinem
Copy link
Member

was this superceded by #649?

@relaxolotl
Copy link
Contributor Author

yeah, the combination of #649, #648, #651, #652, and #656 makes this obsolete. closing since we don't really need this anymore

@relaxolotl relaxolotl closed this Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants