-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Capture registers with inproc backend (FEEDBACK-1413) #714
Conversation
I tested this on my m1 mbp and added register writes via inline assembly right before the crash and could see most of the general-purpose registers survive into the disk dump of the event. I think you tested it on all OS+Arch combos I could provide besides that. But please let me know if further target-testing makes sense. |
I tested this only on x64 on all OSs. I would like to have someone give it a spin on 32/64-bit Android as well. |
I can test Android only on the emulator and give aarch64 on Linux a try. But both probably not before Wednesday. |
I tested this on aarch64 under Linux where it works correctly. I also tried to test this in android using the emulator. I can see that an aarch64 register dump is created in the sentry-native database path on the device, but I cannot really stress the register values for comparison because the crash-causing function is compiled using an |
@supervacuus Thanks for the investigation! I think this is ready to land in that case. |
No description provided.