Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update breakpad 2023-05-03 #836

Merged
merged 3 commits into from
May 8, 2023

Conversation

supervacuus
Copy link
Collaborator

No description provided.

@supervacuus supervacuus requested a review from Swatinem May 4, 2023 14:28
@supervacuus
Copy link
Collaborator Author

So the issue here: https://github.com/getsentry/sentry-native/actions/runs/4884009202/jobs/8716134172#step:11:514 is related to a change that adds new in favor of deprecated APIs: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4437109/13/src/common/mac/arch_utilities.cc

The problem is that we cannot use __builtin_available() here since arch_utilities.cc depends on a system header (mach-o/utils.h) that isn't available in earlier SDKs (like the one in our CI). If we want to keep the compatibility with previous SDKs (and it seems that was also the intention upstream), then we must guard the include (as well as the code below) with something like this:

#if defined(__APPLE__) && (defined(__MAC_13_0) || defined(__IPHONE_16_0))
#include <mach-o/utils.h>
#endif

This would eliminate the warning pragmas if applied to the dependent functions below. While I can easily change this in our breakpad fork, I think it might be the right call to upstream this to understand the intention behind the change.

@supervacuus supervacuus merged commit d30e96d into master May 8, 2023
@supervacuus supervacuus deleted the chore/update_breakpad_2023_05_03 branch May 8, 2023 15:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants