Add TransactionContext::make() & SpanContext::make() (#1684)

getsentry · Jan 18, 2024 · 62274fb · 62274fb
1 parent 1cc36e6
commit 62274fb
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/src/Tracing/SpanContext.php b/src/Tracing/SpanContext.php
@@ -61,6 +61,14 @@ class SpanContext
      */
     private $endTimestamp;
 
+    /**
+     * @return self
+     */
+    public static function make()
+    {
+        return new self();
+    }
+
     public function getDescription(): ?string
     {
         return $this->description;

diff --git a/src/Tracing/TransactionContext.php b/src/Tracing/TransactionContext.php
@@ -42,6 +42,14 @@ public function __construct(
         $this->metadata = $metadata ?? new TransactionMetadata();
     }
 
+    /**
+     * @return self
+     */
+    public static function make()
+    {
+        return new self();
+    }
+
     /**
      * Gets the name of the transaction.
      */

diff --git a/tests/Tracing/SpanTest.php b/tests/Tracing/SpanTest.php
@@ -56,7 +56,7 @@ public function testStartChild(): void
             ->setSpanId(SpanId::generate())
             ->setTraceId(TraceId::generate());
 
-        $spanContext2 = (new SpanContext())
+        $spanContext2 = SpanContext::make()
             ->setSampled(true)
             ->setParentSpanId($spanContext2ParentSpanId)
             ->setTraceId($spanContext2TraceId);

diff --git a/tests/Tracing/TransactionTest.php b/tests/Tracing/TransactionTest.php
@@ -28,7 +28,7 @@ public function testFinish(): void
         ClockMock::withClockMock(1600640877);
 
         $expectedEventId = null;
-        $transactionContext = (new TransactionContext())
+        $transactionContext = TransactionContext::make()
             ->setTags(['ios_version' => '4.0'])
             ->setSampled(true)
             ->setStartTimestamp(1600640865);