Add AppVeyor to CI pipeline (#758)

.appveyor.yml

@@ -0,0 +1,33 @@
+version: 2.x-{build}
+build: false
+clone_depth: 2
+clone_folder: c:\projects\sentry-php
+skip_branch_with_pr: true
+
+cache:
+  - composer.phar
+  - '%LocalAppData%\Composer\files'
+  - c:\projects\sentry-php\vendor
+
+init:
+  - SET PATH=c:\php;%PATH%
+  - SET COMPOSER_NO_INTERACTION=1
+  - SET SYMFONY_DEPRECATIONS_HELPER=strict
+  - SET ANSICON=121x90 (121x90)
+
+install:
+  - mkdir c:\php && cd c:\php
+  - appveyor DownloadFile https://github.com/symfony/binary-utils/releases/download/v0.1/php-7.1.3-Win32-VC14-x86.zip
+  - 7z x php-7.1.3-Win32-VC14-x86.zip -y >nul
+  - echo memory_limit=-1 >> php.ini
+  - echo extension=php_curl.dll >> php.ini
+  - echo extension=php_mbstring.dll >> php.ini
+  - echo extension=php_openssl.dll >> php.ini
+  - cd c:\projects\sentry-php
+  - IF NOT EXIST composer.phar (appveyor DownloadFile https://github.com/composer/composer/releases/download/1.7.1/composer.phar)
+  - php composer.phar self-update
+  - php composer.phar update --no-progress --no-suggest --ansi
+
+test_script:
+  - cd c:\projects\sentry-php
+  - vendor\bin\phpunit.bat

src/Context/ServerOsContext.php

@@ -186,7 +186,7 @@ public function setKernelVersion(string $kernelVersion): void
     private function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setDefaults([
-            'name' => PHP_OS,
+            'name' => php_uname('s'),
             'version' => php_uname('r'),
             'build' => php_uname('v'),
             'kernel_version' => php_uname('a'),

src/Options.php

@@ -720,14 +720,6 @@ private function normalizeAbsolutePath($value)
             $path = $value;
         }
 
-        if (
-            \DIRECTORY_SEPARATOR === substr($path, 0, 1)
-            && \DIRECTORY_SEPARATOR !== substr($path, -1)
-            && '.php' !== substr($path, -4)
-        ) {
-            $path .= \DIRECTORY_SEPARATOR;
-        }
-
         return $path;
     }
 

tests/ClientTest.php

@@ -175,11 +175,14 @@ public function testCaptureLastErrorDoesNothingWhenThereIsNoError(): void
         $client->captureLastError();
     }
 
+    /**
+     * @requires OSFAMILY Linux
+     */
     public function testAppPathLinux(): void
     {
         $client = ClientBuilder::create(['project_root' => '/foo/bar'])->getClient();
 
-        $this->assertEquals('/foo/bar/', $client->getOptions()->getProjectRoot());
+        $this->assertEquals('/foo/bar', $client->getOptions()->getProjectRoot());
 
         $client->getOptions()->setProjectRoot('/foo/baz/');
 

tests/EventFactoryTest.php

@@ -180,6 +180,9 @@ public function testCreateWithStacktrace(): void
         /** @var Frame $lastFrame */
         $lastFrame = array_reverse($stacktrace->getFrames())[0];
 
-        $this->assertSame('src/EventFactory.php', $lastFrame->getFile());
+        $this->assertSame(
+            'src' . \DIRECTORY_SEPARATOR . 'EventFactory.php',
+            ltrim($lastFrame->getFile(), \DIRECTORY_SEPARATOR)
+        );
     }
 }

tests/OptionsTest.php

@@ -239,7 +239,7 @@ public function excludedPathProviders()
         return [
             ['some/path', 'some/path'],
             ['some/specific/file.php', 'some/specific/file.php'],
-            [__DIR__, __DIR__ . '/'],
+            [__DIR__, __DIR__],
             [__FILE__, __FILE__],
         ];
     }