Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cron Monitor upsert #1511

Merged
merged 10 commits into from
Jun 13, 2023
Merged

feat: Cron Monitor upsert #1511

merged 10 commits into from
Jun 13, 2023

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Apr 5, 2023

$checkIn = new CheckIn(
    monitorSlug: 'upsert-monitor',
    status: CheckInStatus::inProgress(),
    release: '1.0.0',
    environment: 'production',
    monitorConfig: (new MonitorConfig(
        schedule: MonitorSchedule::crontab('*/5 * * * *'),
        // or
        schedule: MonitorSchedule::interval(
            value: 30,
            unit: MonitorScheduleUnit::minute(),
        )),
        checkinMargin: 5,
        maxRuntime: 30,
        timezone: 'UTC',
    )),
);

@cleptric cleptric self-assigned this Apr 5, 2023
@cleptric cleptric force-pushed the cron-upsert branch 2 times, most recently from 9c1acd8 to e16ca4b Compare April 5, 2023 09:47
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cleptric please take another look after my changes, but I think this looks pretty decent!

@cleptric cleptric marked this pull request as ready for review June 13, 2023 04:35
@cleptric cleptric merged commit d907d27 into master Jun 13, 2023
@cleptric cleptric deleted the cron-upsert branch June 13, 2023 05:13
will2877 added a commit to will2877/sentry-symfony that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants