Strip path prefixes on profile frames

[stayallive]

This was an open TODO that is resolved!

[ste93cry]

Wouldn't be better to make PrefixStripper a final class with a static method accepting the list of prefixes instead of using a trait?

[stayallive]

That could also work yes. I don't think there is a technical reason why either way is "better" so potato, potahto really in this case 😄

[cleptric]

A quick test run with some app that reports to https://sentry.io would be appreciated, besides that,

[ste93cry]

That could also work yes. I don't think there is a technical reason why either way is "better"

Some of the reasons I can think of is that:

• Even if not impossible, they are more difficult to test than a class or a method
• They introduce horizontal inheritance, so understanding a code base can be significantly harder. Injecting a dependency is a lot cleaner in this aspect, as you make it clear what a class needs to work. But in this case, a static helper method would probably be enough
• Since a trait is basically a way to copy-paste some code in multiple places, you are effectively coupling it with the classes it will be used in, risking to make some change in one that doesn't suit the others. In this case the method does not access anything on $this, but you never know in the future what could happen.

Lately I've seen a lot of discussions around traits and why people think they are either good or bad. Honestly I don't have a real strong opinion on this, and in this case I agree that it doesn't really matter probably, but if it was me I would have created an helper class. Also, I don't like passing around all the client config when the function really needs just a plain array of strings. Also, the method is not static (so it can access the instance properties), but it takes the options from its arguments 🤔

If you really want to leave it as-is, I would at least add the Trait suffix to the trait to make it explicit what is it.

[stayallive]

For the requested sentry.io test (using a Laravel application):

Before:

After:

Looks a lot better to me 😎