Update PHPCS #1599
Merged
Update PHPCS #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleptric
force-pushed
the
update-github-actions
branch
from
c2967a3 to
3ea33c9
Compare
cleptric
force-pushed
the
update-github-actions
branch
from
9f44aed to
36a1dee
Compare
cleptric
commented
Oct 24, 2023
| 'yoda_style' => true, | ||
| 'self_accessor' => false, | ||
| 'phpdoc_no_useless_inheritdoc' => false, | ||
| 'modernize_strpos' => false, |
There was a problem hiding this comment.
str_contains is only available from PHP 8.0
cleptric
commented
Oct 24, 2023
| @@ -10,9 +10,16 @@ | |||
| 'imports_order' => ['class', 'function', 'const'], | |||
| ], | |||
| 'declare_strict_types' => true, | |||
| 'get_class_to_class_keyword' => false, | |||
There was a problem hiding this comment.
PHP Fatal error: Cannot use ::class with dynamic class name in PHP 7.4 and below
cleptric
commented
Oct 24, 2023
| 'phpdoc_no_useless_inheritdoc' => false, | ||
| 'modernize_strpos' => false, | ||
| 'nullable_type_declaration_for_default_null_value' => [ | ||
| 'use_nullable_type_declaration' => true, |
There was a problem hiding this comment.
This would remove way too many ? types.
cleptric
commented
Oct 24, 2023
| 'use_nullable_type_declaration' => true, | ||
| ], | ||
| 'no_superfluous_phpdoc_tags' => [ | ||
| 'allow_mixed' => true, |
There was a problem hiding this comment.
This would remove all @mixed annotations, which makes phpstan unhappy.
cleptric
force-pushed
the
update-github-actions
branch
from
519dcf5 to
4c57972
Compare
# Conflicts: # src/Options.php # tests/Integration/IgnoreErrorsIntegrationTest.php
stayallive
added a commit
that referenced
this pull request
Oct 24, 2023
stayallive
added a commit
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.