Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Spotlight #1647

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Add support for Spotlight #1647

merged 2 commits into from
Nov 29, 2023

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Nov 22, 2023 •
edited
Loading

Spotlight is Sentry for Development. Inspired by an old project Django Debug Toolbar. Spotlight brings a rich debug overlay into development environments, and it does it by leveraging the existing power of Sentry's SDKs.

Opted to add a new HTTP client for this, as it diverges heavily from our regular one.

image

image

Blocked by getsentry/spotlight#111

@cleptric cleptric self-assigned this Nov 22, 2023
@cleptric cleptric requested a review from stayallive November 22, 2023 19:01
@natikgadzhi natikgadzhi mentioned this pull request Nov 23, 2023
Merged
3 tasks
stayallive
stayallive approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks, but nothing major 🪨

src/Transport/HttpTransport.php Outdated Show resolved Hide resolved
src/Transport/HttpTransport.php Outdated Show resolved Hide resolved
src/Transport/HttpTransport.php Show resolved Hide resolved
@cleptric cleptric enabled auto-merge (squash) November 29, 2023 13:04
@cleptric cleptric merged commit 65d4e2d into master Nov 29, 2023
31 checks passed
@cleptric cleptric deleted the spotlight branch November 29, 2023 13:06
@bruno-garcia bruno-garcia mentioned this pull request Dec 7, 2023
Closed
This was referenced Dec 13, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

@natikgadzhi natikgadzhi natikgadzhi left review comments

Assignees

@cleptric cleptric

Labels
Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cleptric @natikgadzhi @stayallive