Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_ssl_verify_peer sets CURLOPT_SSL_VERIFYPEER correctly #1686

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

tanenbaum
Copy link
Contributor

CURLOPT_SSL_VERIFYPEER is by default true. Set to false when http_ssl_verify_peer is false instead to override the default.

CURLOPT_SSL_VERIFYPEER is by default true. Set to false when http_ssl_verify_peer is false.
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that makes sense 😅

Curious about the use you had for needing to use this option!

@tanenbaum
Copy link
Contributor Author

Curious about the use you had for needing to use this option!

I'm testing against a server with a self-signed cert - I've just upgraded the php dep to 4.x. Previously on 3.x I had a custom transport factory that allowed setting those curl options, although I may need to do that again with CURLOPT_SSL_VERIFYHOST too.

The next problem I have is the php 8 alpine image I'm using doesn't seem to obey any of these curl settings 😭 - but that's nothing to do with this library, not even the curl --insecure command works 🤷‍♂️

@tanenbaum
Copy link
Contributor Author

Hey @stayallive what's the typical timeline around getting fixes merged and released?

I'm trying to decide if I should drop in my own http client implementation (duplicating this one essentially) or wait for a release. Thanks!

@cleptric cleptric enabled auto-merge (squash) January 22, 2024 12:01
@cleptric cleptric merged commit 40ddd18 into getsentry:master Jan 22, 2024
31 checks passed
@cleptric
Copy link
Member

We'll get this released today/tomorrow.

@tanenbaum
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants