Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hint float on metrics calls #1745

Merged
merged 1 commit into from
May 28, 2024
Merged

Type hint float on metrics calls #1745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/Metrics/Metrics.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,11 @@ public static function getInstance(): self
}

/**
* @param int|float $value
* @param array<string, string> $tags
*/
public function increment(
string $key,
$value,
float $value,
?MetricsUnit $unit = null,
array $tags = [],
?int $timestamp = null,
Expand All @@ -63,12 +62,11 @@ public function increment(
}

/**
* @param int|float $value
* @param array<string, string> $tags
*/
public function distribution(
string $key,
$value,
float $value,
?MetricsUnit $unit = null,
array $tags = [],
?int $timestamp = null,
Expand All @@ -86,12 +84,11 @@ public function distribution(
}

/**
* @param int|float $value
* @param array<string, string> $tags
*/
public function gauge(
string $key,
$value,
float $value,
?MetricsUnit $unit = null,
array $tags = [],
?int $timestamp = null,
Expand Down
Loading