Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retrieving a single piece of data from the span by it’s key #1767

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

stayallive
Copy link
Collaborator

Add data get helper:

// Old:
$span->setData([
    'failure' => $span->getData()['failure'] + 1,
]);

// New:
$span->setData([
    'failure' => $span->getData('failure', 0) + 1,
]);

@stayallive stayallive requested a review from cleptric August 1, 2024 07:16
@stayallive stayallive self-assigned this Aug 1, 2024
@stayallive stayallive mentioned this pull request Aug 1, 2024
@cleptric cleptric enabled auto-merge (squash) August 5, 2024 11:44
@cleptric cleptric merged commit ec033e3 into master Aug 5, 2024
33 checks passed
@cleptric cleptric deleted the retrieve-single-key-from-span-data branch August 5, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants