Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude anonymous frames from app path #482

Merged
merged 5 commits into from
Sep 27, 2017
Merged

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jul 26, 2017

Fixes GH-481

@dcramer
Copy link
Member Author

dcramer commented Jul 26, 2017

screenshot 2017-07-26 12 04 17

@dcramer dcramer requested review from stayallive and Jean85 July 26, 2017 16:06
@stayallive
Copy link
Collaborator

If we have a class set for the exception we could maybe use reflection to find the file for the class to determine a little better if it's in the app context or not... or is that a stupid idea?

array:4 [▼
  "function" => "Illuminate\Routing\{closure}"
  "class" => "Illuminate\Routing\Router"
  "type" => "->"
  "args" => array:1 [▶]
]
// Return either the filename or false if it's defined in the core or extension.
$filename = (new ReflectionClass('Illuminate\Routing\Router'))->getFileName();

@Jean85
Copy link
Collaborator

Jean85 commented Jul 27, 2017

I expressed my concerns here: #481 (comment)

@dcramer dcramer merged commit 501ebd9 into master Sep 27, 2017
@dcramer dcramer deleted the fix/anonymous-app-path branch September 27, 2017 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants