Fix bug that prevented to filter sensitive data when there is an exception with multiple 'values' #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption with multiple 'values'
|
Good catch! |
stayallive
approved these changes
Aug 2, 2017
Jean85
approved these changes
Aug 2, 2017
|
@stayallive do we backport this to the 1.7.x branch to release a 1.7.1 patch immediately? |
|
@Jean85 I would say yes. This has a low impact since it will be catched by the server correctly IIRC, it does still travel over an (https) connection which can be prevented. |
Jean85
pushed a commit
that referenced
this pull request
Aug 2, 2017
(cherry picked from commit e2f3c47)
Merged
|
Done: https://github.com/getsentry/sentry-php/releases/tag/1.7.1 |
Jean85
added a commit
that referenced
this pull request
Aug 2, 2017
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was reviewing the code to make sure that sensitive data is correctly filtered, I noticed the following bug: if the exception has 2 arrays in
'values'key, only the 1st one is correctly filtered.The reason is because there is a not necessary
returnthat I removed to fix the bug.Obviously I also verified that all the callers of this function didn't use its return value. It's likely a bug introduced when porting the implementation from another language where a callback or similar has been used.
Also added test to make sure a regression can not be introduced.