-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 7.2 in CI #489
Add PHP 7.2 in CI #489
Conversation
There is a session related failure, but there seems to be a few session fixes in 7.2.0beta3, and right now I'm only able to test on beta2 due to Docker Hub availability; I will wait a few days before going forward with this. |
Nevermind, it seems that the deprecation doesn't make the build fail. There is still something that trigger the failure, I'm working on isolating it. |
I'm missing something... But how's that it doesn't bother lower PHP versions? |
This is just a test. I think you can suppress this warning |
Please apply this patch https://pastebin.com/wUf9jgk7 I want to make PR, but it is already created. We need to add PHP 7.2 to supported versions. RC3 is already here http://php.net/archive/2017.php#id2017-09-28-2 We can not wait anymore. |
@nokitakaze You can create a PR to this branch if you'd like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need add PHP 7.2 as supported. RC-3 is already here
Thanks @nokitakaze for the help!! |
This is still WIP, it seems that we are getting warning that I would like to investigate further.