Add setters for Raven Serializes #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be fine with this I think. @Jean85 what are your thoughts? Assuming this is already implemented in 2.0, but still be usefull in 1.x. |
|
Nope, this is not implemented in 2.0, so it could be ported there to. Can we add some tests? |
|
@atuzlukov would you be able to add some tests for this functionality? |
atuzlukov
force-pushed
the
feature/configure-serializers
branch
from
4a2c4df to
498f3f0
Compare
|
@stayallive @Jean85 Added tests for serialize setters |
Jean85
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Add the ability to install a custom serializer. For example, instead of the phrase "Array of length 3" put a serialized array, so as not to lose valuable data during the logging