Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs config #570

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Update docs config #570

merged 1 commit into from
Mar 19, 2018

Conversation

stayallive
Copy link
Collaborator

Currently the generic php instructions are prepended on the Laravel & Symfony getting started pages in Sentry, this should not be the case since they are not needed and confusing at best.

Also added Laravel 4.x & Lumen 5.x instructions to that page.

Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I should update the info in the Symfony step, where are those stored?

@stayallive
Copy link
Collaborator Author

Yeah it;s a bit weird but those docs are here: https://github.com/getsentry/sentry-php/tree/master/docs/integrations

We probably would do good to just link there from the README.md maybe and only keep this as the source of truth for the docs since otherwise they just keep getting out of sync.

@stayallive stayallive merged commit ec5a234 into master Mar 19, 2018
@stayallive stayallive deleted the update-docs-config branch March 19, 2018 10:34
@stayallive stayallive restored the update-docs-config branch March 20, 2018 12:52
@stayallive stayallive deleted the update-docs-config branch March 20, 2018 12:53
@Jean85 Jean85 mentioned this pull request May 3, 2018
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants