Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excluded_exceptions that is compatible with 2.0 #583

Merged
merged 1 commit into from
Apr 20, 2018

Conversation

mcfedr
Copy link
Contributor

@mcfedr mcfedr commented Apr 19, 2018

So, given that I'm sticking with 1.x for the moment, I have made this solution, and I thought I'd share it as it might be interesting to you. I'm probably going to be deploying this on my server now.

Basically, instead of changing how exclude works, I've added a new option, excluded_exceptions that works just like it does in 2.0, and how I need it to work, excluding all subclasses.

As a bonus might make upgrade path simpler for people as they can start using excluded_exceptions in 1.X

- Allows exclude subclasses and implementations of exceptions
@stayallive stayallive requested review from Jean85 and stayallive April 19, 2018 09:20
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be fine with this, i'm not to sure about the name but don't have a better suggestion so 👍

@mcfedr
Copy link
Contributor Author

mcfedr commented Apr 19, 2018

@stayallive I figured as its been renamed in 2.0, lets use the same name, as it has the same functionality.

@ste93cry
Copy link
Collaborator

ste93cry commented Apr 19, 2018

As 2.0 is still in development and there is time to make things well, if anyone has a better name for the option I'm open to suggestions. Please note that the name (excluded_exceptions) is the same for the Ruby SDK

@stayallive
Copy link
Collaborator

stayallive commented Apr 19, 2018

Ah did not notice that, I think it's fine then 👍

(FYI: build failure not because this PR)

Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion. Can we make the exclude option deprecated to explicit better that this is the upgrade path?

As for the name, I'm fine with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants