[2.0] Support longer creditcard numbers #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
ste93cry
reviewed
Aug 3, 2018
| @@ -125,7 +125,19 @@ public function processDataProvider() | |||
| [ | |||
| [ | |||
| 'extra_context' => [ | |||
| 'ccnumba' => '4242424242424242', | |||
| 'ccnumba' => str_repeat('9', 13), | |||
There was a problem hiding this comment.
Just a minor comment, feel free to ignore it: does it really makes sense to not write the string and instead use str_repeat?
There was a problem hiding this comment.
I did it just for readability, so the length of the test string is immediately clear.
ste93cry
approved these changes
Aug 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports #635 manually to 2.0