Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added passing data from context in monolog breadcrumb handler #683

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Added passing data from context in monolog breadcrumb handler #683

merged 2 commits into from
Nov 8, 2018

Conversation

dmyers
Copy link
Contributor

@dmyers dmyers commented Oct 31, 2018

This simple change is very useful for breadcrumbs when using monolog. My app uses Monolog via Laravel and I think others will want this behavior too.

Before:
screen shot 2018-10-31 at 2 31 58 pm

After:
screen shot 2018-10-31 at 2 32 21 pm

@Jean85
Copy link
Collaborator

Jean85 commented Nov 2, 2018

This is a very good catch! Can you add tests for this change?

@dmyers
Copy link
Contributor Author

dmyers commented Nov 5, 2018

Thanks, glad you like it. I've been working with the breadcrumbs and it's a very powerful feature.

Does this test seem good? I tested on my computer and made it similar to the other one with the added context assertion.

Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link

@ruudk ruudk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything holding back this PR from merging? It would make my life so much easier if this was merged and tagged 🙏

@Jean85
Copy link
Collaborator

Jean85 commented Nov 8, 2018

Nope, it's good, let's merge!

@Jean85 Jean85 merged commit 5c19be5 into getsentry:master Nov 8, 2018
@ruudk
Copy link

ruudk commented Nov 8, 2018

@Jean85 For my info, what is the release process for new tagged releases? Then I know if I can wait or need to use my own fork on production.

@Jean85
Copy link
Collaborator

Jean85 commented Nov 9, 2018

I suggest you to use this fork, since it's the only difference from the last tagged version and I can't guarantee when the next tag will be done.

@ruudk
Copy link

ruudk commented Nov 9, 2018

I see 18 changes? 1.9.2...master

@Jean85
Copy link
Collaborator

Jean85 commented Nov 9, 2018

Oh sorry, I was mixing up with the Symfony integration that I just released. In this case I think that we can ask @stayallive that did the last 2 or 3 tags.

@stayallive
Copy link
Collaborator

I think we can definitely whip up another release. Let me set that up today.

@ruudk
Copy link

ruudk commented Nov 9, 2018

Thanks guys !! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants