Add PHP 7.3 to Travis CI build and support EditorConfig #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
force-pushed
the
php7.3-travisci
branch
2 times, most recently
from
ce15f7d to
8b1fe3e
Compare
ste93cry
force-pushed
the
php7.3-travisci
branch
from
8b1fe3e to
9084fc7
Compare
Jean85
approved these changes
Jan 22, 2019
|
I believe it is because otherwise you could not be sure that the lowest dependencies actually runs on a specific version of PHP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 7.3 is out we can now add it to the TravisCI pipeline. I've also added support for EditorConfig and changed the steps order to ensure that PHPStan runs first. The reason why I decided to do it is that it makes sense for a static analysis tool to runs first since things that it reports are likely to be bugs that should be fixed regardless of the CI build result, so knowing that there is something wrong as soon as possible is better