Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppVeyor status badge #765

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Add AppVeyor status badge #765

merged 2 commits into from
Feb 7, 2019

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Feb 5, 2019

After #758 I forgot a small additional change: the badge!

@ste93cry
Copy link
Collaborator

ste93cry commented Feb 5, 2019

Isn't there an AppVeyor badge that resembles the others? The current one (the official I believe) has a totally different style 😞) Also why viewing the preview of the file the build is reported as failing?

Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it should try to fit in better 😄 (but how could you forget the badge in the first place 😜)

README.md Outdated Show resolved Hide resolved
Co-Authored-By: Jean85 <alessandro.lai85@gmail.com>
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming there is something wrong with the status ont eh AppVeyor side, this seems like the correct implementation. LGTM! 🚀

@ste93cry ste93cry merged commit d451b2f into master Feb 7, 2019
@ste93cry ste93cry deleted the appveyor-badge branch February 7, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants