-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add http proxy option for curl client #775
Conversation
I'm entirely 👎 on this change, there have been a lot of discussions already about why the SDK client should not know the HTTP client implementation (this is why we have the concept of transports). I obviously see the convenience of having such option available and its value, but I strongly believe that if someone wants to set it then he has to set its own client. It's not that hard after all and we're devs, so it should not be a problem for us to understand how something we're using works since it's our job... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the best of the worst options, best we can do right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with both @ste93cry and @stayallive: I would prefer not to include this option, but if we really must, this is the least painful way to do it.
Only required changes:
- make it fail hard if it's misconfigured, like setting a custom transport AND a proxy
- document it thoroughly, so the user knows that there's this limitation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 I've also added a test.
We should add this to the docs.
No description provided.