Add Monolog handler #808
Merged
Add Monolog handler #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
approved these changes
Apr 23, 2019
Jean85
approved these changes
Apr 26, 2019
|
We're missing just one small thing! The changelog! |
ste93cry
force-pushed
the
feature/monolog-handler
branch
from
9192e0d to
e8f5aa9
Compare
|
Done, I always forget to update it! |
|
Amazing! Thank you 👍 |
|
Trying to update but am being blocked by this PR not being released. What's the ETA? 😄 |
|
No ETA, but this will be released with 2.1. Check out the milestone for progress: https://github.com/getsentry/sentry-php/milestone/2 |
|
Alright, thanks for the reply! I'll check back in a while and stay at sentry/sentry-symfony 2.x for now as it seems to not cause issues with Symfony 4.x |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a Monolog handler and closes #790, which is a highly requested feature. Code is a stripped down version of the one submitted by @HazAT in the official Monolog repository. There are a few questions to discuss before merging:
Hub::setCurrent()method is called) it's not clear how this should affect the handler itself: e.g. if the handler is binded to an old or different hub than the current one it will report errors to the wrong client (if it's different between hubs)captureMessagemethod provides no way to pass the exception while calling thecaptureExceptionhas no way to pass the message. To solve the issue, instead of calling those methods like in the original PR, I'm building the raw payload of data to build the event from and I'm using thecaptureEventmethod directly. Since the two methods mentioned before have a slightly different behavior regarding the stacktrace capture (attach_stacktraceoption), the same exact behavior cannot be accomplished with such way