Allow numeric value in tags. #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
requested changes
Jul 25, 2019
ste93cry
requested changes
Jul 25, 2019
|
Still missing the documentation of the private function, apart from that it seems fine to me 👍 |
|
@ste93cry Doc added, sorry for the poor English. |
|
Any chance to merge this PR? |
Jean85
approved these changes
Jul 30, 2019
|
@leo108 I did some changes to your PR, please let me know if you're ok with them |
|
@ste93cry LGTM, Thanks. |
stayallive
approved these changes
Jul 30, 2019
ste93cry
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a very common scene that we use a numeric value as a tag, e.g. user id.
Developers are not always aware that should pass a real string value to Sentry's TagsContext, and InvalidArgumentException thrown in Sentry may not be caught by framework's exception handler because Sentry is called in the exception handler in most cases, thus no error logs in framework nor reports in Sentry, which makes it hard to track error.