feat: formulas in timeseries and traceitemtable endpoints #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
phacops
requested changes
Jan 29, 2025
|
renamed left, right, expression |
phacops
approved these changes
Jan 29, 2025
This was referenced Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are we reimplementing snql? Who knows, but I am certainly reimplementing the grammar of a query language.
This allows
add,subtract,multiply, anddivideto be specified as operations in the "select" of timeseries endpoint and traceitemtableThe reason I nested
BinaryFormulainside ofmessage Columninstead of making it separate is bc of the imports between timeseries and traceitemtable. It wouldnt let me name both messagesBinaryFormulasince it would be a duplicate object defined twice.