Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add response status code to transaction response context #2289

Closed
Tracked by #9
sentrivana opened this issue Aug 2, 2023 · 0 comments · Fixed by #2312
Closed
Tracked by #9

Add response status code to transaction response context #2289

sentrivana opened this issue Aug 2, 2023 · 0 comments · Fixed by #2312
Assignees
@antonpirker

Comments

@sentrivana
Copy link
Contributor

sentrivana commented Aug 2, 2023 •
edited
Loading

Problem Statement

Make sure we save the status code in contexts.response.status_code for transactions.

See also

Solution Brainstorm

Do it.
@sentrivana sentrivana mentioned this issue Aug 2, 2023
Closed
@sentrivana sentrivana changed the title Add response status to transaction response context Add response status code to transaction response context Aug 2, 2023
@antonpirker antonpirker self-assigned this Aug 16, 2023
@antonpirker antonpirker mentioned this issue Aug 17, 2023
Merged
antonpirker added a commit that referenced this issue Aug 29, 2023
@antonpirker
Set response status code in transaction "response" context. (#2312)
46c24ea 
Make sure that the HTTP response status code be set in the transactions "response" context.

This works in WSGI (was already calling set_http_status.) Also added this to ASGI projects.

Fixes #2289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonpirker antonpirker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set response status code in transaction "response" context. getsentry/sentry-python
2 participants
@antonpirker @sentrivana