Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve POTel span/description/status logic #3236

Closed
sl0thentr0py opened this issue Jul 2, 2024 · 0 comments
Closed

Improve POTel span/description/status logic #3236

sl0thentr0py opened this issue Jul 2, 2024 · 0 comments
Assignees
@antonpirker
Labels
Integration: OpenTelementry (OTel) Project: POTel
Milestone
Performance power...

Comments

@sl0thentr0py
Copy link
Member

sl0thentr0py commented Jul 2, 2024 •
edited
Loading

@sentrivana moved op/description/status logic to utils, but status mapping will be done separately. Maybe @szokeasaurusrex can look into making this logic as similar to JS as possible, but for now this is good enough for this PR.

https://github.com/getsentry/sentry-javascript/blob/master/packages/opentelemetry/src/utils/mapStatus.ts
https://github.com/getsentry/sentry-javascript/blob/master/packages/opentelemetry/src/utils/parseSpanDescription.ts

Originally posted by @sl0thentr0py in #3223 (comment)
@antonpirker antonpirker mentioned this issue Jul 9, 2024
Merged
@szokeasaurusrex szokeasaurusrex removed their assignment Jul 16, 2024
antonpirker added a commit that referenced this issue Jul 26, 2024
@antonpirker @sl0thentr0py @sentrivana
Span description, op, and status improvements (#3259)
980b268 
Improved extraction of op, description, status and http_status for a Sentry span from an OpenTelemenetry span.

Fixes #3236

---------

Co-authored-by: Neel Shah <neel.shah@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonpirker antonpirker

Labels
Integration: OpenTelementry (OTel) Project: POTel
Projects
None yet
Milestone
Performance powered by OTel (POTel)
Development

No branches or pull requests
4 participants
@antonpirker @sl0thentr0py @szokeasaurusrex @sentrivana