Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sqlalchemy engine.name being bytes #2074

Merged
merged 1 commit into from
May 4, 2023

Conversation

sentrivana
Copy link
Contributor

There are cases where engine.name in sqlalchemy is not a string (see #2071).

Fixes #2071

@antonpirker antonpirker merged commit 92e24b4 into master May 4, 2023
@antonpirker antonpirker deleted the ivana/pyhive-typeerror branch May 4, 2023 10:09
Copy link

@pedrorivotti pedrorivotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small drive-by note.

@@ -111,6 +112,8 @@ def _handle_error(context, *args):
# See: https://docs.sqlalchemy.org/en/20/dialects/index.html
def _get_db_system(name):
# type: (str) -> Optional[str]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type: (str) is no longer necessarily accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility between sentry-sdk and PyHive
3 participants