Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use functools.wrap for ThreadingIntegration patches to fix attributes #2080

Merged
merged 1 commit into from
May 5, 2023

Conversation

EpicWink
Copy link
Contributor

@EpicWink EpicWink commented May 5, 2023

Should fix compatibility with OpenCensus threading integration

fixes #2076

Should fix compatibility with OpenCensus threading integration
@EpicWink EpicWink force-pushed the thread-wrapper-attributes branch from 455f1b0 to cec18e1 Compare May 5, 2023 06:26
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty @EpicWink!

@sl0thentr0py sl0thentr0py changed the title Update threading method wrapper attributes Use functools.wrap for ThreadingIntegration patches to fix attributes May 5, 2023
@sl0thentr0py sl0thentr0py enabled auto-merge (squash) May 5, 2023 11:34
@sl0thentr0py sl0thentr0py merged commit 2610c66 into getsentry:master May 5, 2023
@EpicWink EpicWink deleted the thread-wrapper-attributes branch May 6, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threading integration breaks OpenCensus' threading integration
2 participants