Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Add Spark testsuite to tox.ini and to CI #3199

Merged
merged 7 commits into from
Jun 25, 2024
Merged

fix(tests): Add Spark testsuite to tox.ini and to CI #3199

merged 7 commits into from
Jun 25, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jun 25, 2024 •
edited
Loading

😬

The testsuite is there, but Spark is completely missing from tox.ini and it's also not run in CI.

@sentrivana sentrivana added Component: Tests Dealing with tests Component: CI Dealing with Github Actions labels Jun 25, 2024
@sentrivana sentrivana changed the title fix(tests): Test Spark integration in CI fix(tests): Add Spark to tox.ini and to CI Jun 25, 2024
@sentrivana sentrivana changed the title fix(tests): Add Spark to tox.ini and to CI fix(tests): Add Spark testsuite to tox.ini and to CI Jun 25, 2024
@sentrivana sentrivana marked this pull request as ready for review June 25, 2024 11:34
@sentrivana sentrivana requested review from szokeasaurusrex and antonpirker and removed request for szokeasaurusrex June 25, 2024 11:34
szokeasaurusrex
szokeasaurusrex approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, please address the inline question before merging

.github/workflows/test-integrations-data-processing.yml Show resolved Hide resolved
@sentrivana sentrivana merged commit bcc563c into master Jun 25, 2024
119 checks passed
@sentrivana sentrivana deleted the ivana/test-spark branch June 25, 2024 11:51
antonpirker pushed a commit that referenced this pull request Jun 25, 2024
@sentrivana @antonpirker
fix(tests): Add Spark testsuite to tox.ini and to CI (#3199)
f5dd9ce
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
@sentrivana @arjenzorgdoc
fix(tests): Add Spark testsuite to tox.ini and to CI (getsentry#3199)
92f48bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
Component: CI Dealing with Github Actions Component: Tests Dealing with tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sentrivana @antonpirker @szokeasaurusrex