-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(profiling): Add client sdk info to profile chunk #3386
feat(profiling): Add client sdk info to profile chunk #3386
Conversation
We want to attach the client sdk info for debugging purposes.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3386 +/- ##
==========================================
+ Coverage 79.71% 79.72% +0.01%
==========================================
Files 132 132
Lines 14264 14267 +3
Branches 3003 3003
==========================================
+ Hits 11370 11375 +5
Misses 2071 2071
+ Partials 823 821 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, but I have some comments and questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
* feat(profiling): Add client sdk info to profile chunk We want to attach the client sdk info for debugging purposes. * address PR comments * use class syntax for typed dict * import Sequence from collections.abc * fix typing --------- Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
* feat(profiling): Add client sdk info to profile chunk We want to attach the client sdk info for debugging purposes. * address PR comments * use class syntax for typed dict * import Sequence from collections.abc * fix typing --------- Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
We want to attach the client sdk info for debugging purposes.