Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): Add client sdk info to profile chunk #3386

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

Zylphrex
Copy link
Member

We want to attach the client sdk info for debugging purposes.

We want to attach the client sdk info for debugging purposes.
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (901a5e8) to head (98ca160).

✅ All tests successful. No failed tests found.

Files Patch % Lines
sentry_sdk/client.py 0.00% 1 Missing ⚠️
sentry_sdk/profiler/continuous_profiler.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3386      +/-   ##
==========================================
+ Coverage   79.71%   79.72%   +0.01%     
==========================================
  Files         132      132              
  Lines       14264    14267       +3     
  Branches     3003     3003              
==========================================
+ Hits        11370    11375       +5     
  Misses       2071     2071              
+ Partials      823      821       -2     
Files Coverage Δ
sentry_sdk/client.py 79.85% <0.00%> (ø)
sentry_sdk/profiler/continuous_profiler.py 82.44% <93.33%> (+0.21%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, but I have some comments and questions

sentry_sdk/_types.py Outdated Show resolved Hide resolved
sentry_sdk/profiler/continuous_profiler.py Outdated Show resolved Hide resolved
sentry_sdk/_types.py Outdated Show resolved Hide resolved
tests/profiler/test_continuous_profiler.py Outdated Show resolved Hide resolved
tests/profiler/test_continuous_profiler.py Outdated Show resolved Hide resolved
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Zylphrex Zylphrex enabled auto-merge (squash) August 6, 2024 14:04
@Zylphrex Zylphrex merged commit 5529c70 into master Aug 6, 2024
124 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/add-client-sdk-info-to-profile-chunk branch August 6, 2024 14:21
sentrivana pushed a commit that referenced this pull request Aug 12, 2024
* feat(profiling): Add client sdk info to profile chunk

We want to attach the client sdk info for debugging purposes.

* address PR comments

* use class syntax for typed dict

* import Sequence from collections.abc

* fix typing

---------

Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
* feat(profiling): Add client sdk info to profile chunk

We want to attach the client sdk info for debugging purposes.

* address PR comments

* use class syntax for typed dict

* import Sequence from collections.abc

* fix typing

---------

Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants