Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport): Remove HttpTransport hub_cls attribute #3412

Merged

Conversation

szokeasaurusrex
Copy link
Member

This change is a prerequisite for #3404.

BREAKING CHANGE: Remove sentry_sdk.transport.HttpTransport's hub_cls attribute.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.12%. Comparing base (3936502) to head (38c879d).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #3412      +/-   ##
==============================================
+ Coverage       77.15%   79.12%   +1.97%     
==============================================
  Files             136      135       -1     
  Lines           15191    14341     -850     
  Branches         3294     3016     -278     
==============================================
- Hits            11721    11348     -373     
+ Misses           2646     2177     -469     
+ Partials          824      816       -8     
Files Coverage Δ
sentry_sdk/transport.py 80.61% <ø> (-0.83%) ⬇️

... and 10 files with indirect coverage changes

This change is a prerequisite for #3404.

BREAKING CHANGE: Remove `sentry_sdk.transport.HttpTransport`'s `hub_cls` attribute.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaursurex/remove-HttpTransport-hub_cls branch from 26d7b1b to 38c879d Compare August 8, 2024 11:08
@szokeasaurusrex szokeasaurusrex merged commit 062a155 into potel-base Aug 9, 2024
120 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaursurex/remove-HttpTransport-hub_cls branch August 9, 2024 10:06
sentrivana pushed a commit that referenced this pull request Aug 12, 2024
This change is a prerequisite for #3404.

BREAKING CHANGE: Remove `sentry_sdk.transport.HttpTransport`'s `hub_cls` attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants