Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for checking if our instrumented libs are python 3.13 compatible #3425

Merged

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Aug 9, 2024

A simple script that parses all libraries we test against from our tox.ini and then checks PyPI if this library already supports the newest Python version (currently 3.13)

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.89%. Comparing base (50ad148) to head (b494239).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3425   +/-   ##
=======================================
  Coverage   79.89%   79.89%           
=======================================
  Files         137      137           
  Lines       15387    15387           
  Branches     2613     2613           
=======================================
+ Hits        12293    12294    +1     
  Misses       2221     2221           
+ Partials      873      872    -1     

see 1 file with indirect coverage changes

@sentrivana
Copy link
Contributor

Ooo I want this!

@antonpirker antonpirker self-assigned this Dec 5, 2024
@antonpirker antonpirker marked this pull request as ready for review December 5, 2024 13:22
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonpirker antonpirker merged commit 5891717 into master Dec 5, 2024
136 checks passed
@antonpirker antonpirker deleted the antonpirker/script-to-check-python-compatibility branch December 5, 2024 13:29
@@ -0,0 +1,3 @@
requests
pathlib
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pathlib has been part of the standard library since Python 3.4: https://docs.python.org/3/library/pathlib.html.

I don't think you want to install this dependency, as it hasn't been updated since 2014: https://pypi.org/project/pathlib/.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! #3863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants