Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hub and related code for good. #3446

Merged
merged 10 commits into from
Aug 14, 2024

Conversation

antonpirker
Copy link
Member

Finally it is the time to delete the Hub for good.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

Copy link

codecov bot commented Aug 13, 2024

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 10533 tests with 1 failed, 9152 passed and 1380 skipped.

View the full list of failed tests

py3.13-common

  • Class name: tests.tracing.test_decorator
    Test name: test_trace_decorator_no_trx

    tests/tracing/test_decorator.py:42: in test_trace_decorator_no_trx
    fake_debug.assert_called_once_with(
    .../hostedtoolcache/Python/3.13.0-rc..../x64/lib/python3.13/unittest/mock.py:988: in assert_called_once_with
    raise AssertionError(msg)
    E AssertionError: Expected 'mock' to be called once. Called 5 times.
    E Calls: [call('Cannot create a child span for %s. Please start a Sentry transaction before calling this function.', 'test_decorator.my_example_function'),
    E call('Killing HTTP transport'),
    E call('background worker got kill request'),
    E call('Killing HTTP transport'),
    E call('background worker got kill request')].

@antonpirker antonpirker marked this pull request as ready for review August 13, 2024 15:50
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@antonpirker antonpirker merged commit 3c5f761 into potel-base Aug 14, 2024
110 checks passed
@antonpirker antonpirker deleted the antonpirker/remove-hub-related-stuff branch August 14, 2024 08:18
@antonpirker antonpirker linked an issue Aug 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Hub and deprecated APIs
2 participants