Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove active flag on POTelSpan #3470

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Aug 28, 2024

This was meant to be used to control whether to create an active or an inactive span, but we've since changed that to be done differently (via a context manager).

Copy link

codecov bot commented Aug 28, 2024

❌ 3994 Tests Failed:

Tests completed Failed Passed Skipped
16699 3994 12705 1916
View the top 3 failed tests by shortest run time
tests.integrations.celery.test_celery test_simple_without_performance[<lambda>2]
Stack Traces | 0s run time
No failure message available
tests.integrations.celery.test_celery test_transaction_events[<lambda>3-success]
Stack Traces | 0s run time
No failure message available
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana merged commit 4331362 into potel-base Aug 28, 2024
6 of 108 checks passed
@sentrivana sentrivana deleted the ivana/potel/remove-active branch August 28, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants