Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore original scope #3485

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Restore original scope #3485

merged 3 commits into from
Aug 30, 2024

Conversation

sentrivana
Copy link
Contributor

  • Restore previous tracing.Scope to keep it free from OTel
  • Add basic start_transaction to PotelScope

@codecov Codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

❌ 3877 Tests Failed:

Tests completed Failed Passed Skipped
16709 3877 12832 1916
View the top 3 failed tests by shortest run time 
tests.integrations.celery.test_celery test_abstract_task[<lambda>1]
Stack Traces | 0s run time 
No failure message available

tests.integrations.celery.test_celery test_abstract_task[<lambda>2]
Stack Traces | 0s run time 
No failure message available

tests.integrations.celery.test_celery test_simple_without_performance[<lambda>2]
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

sl0thentr0py
sl0thentr0py approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@sentrivana sentrivana merged commit 7c4a3a0 into potel-base Aug 30, 2024
9 of 107 checks passed
@sentrivana sentrivana deleted the ivana/potel/restore-og-scope branch August 30, 2024 12:48
@sentrivana sentrivana mentioned this pull request Aug 30, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @sl0thentr0py