-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for async calls in Anthropic and OpenAI integration #3497
Conversation
Thanks for the contribution @vetyy ! I have it on my list and will take a look next week |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3497 +/- ##
==========================================
- Coverage 84.32% 84.29% -0.03%
==========================================
Files 133 133
Lines 14068 14226 +158
Branches 2380 2398 +18
==========================================
+ Hits 11863 11992 +129
- Misses 1471 1489 +18
- Partials 734 745 +11
|
Hey @vetyy ! |
Ok, I have merged this now with out current master and fixed some merge conflicts. Tomorrow I will try to clean it up a bit. Could you have a look at the failing Anthropic test @vetyy? |
Ok, Anthropic sis good with the last commit. I will look at the OpenAI code now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now refactored it a bit, tested it locally with example projects and added missing tests. Ready for merging!
@vetyy your fix has been released in this version: https://pypi.org/project/sentry-sdk/2.17.0/ |
❤️ thank you, much appreciated! |
This code should help resolve this issue: #3496
Thank you for contributing to
sentry-python
! Please add tests to validate your changes, and lint your code usingtox -e linters
.Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.