Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context-friendly use_scope, use_isolation_scope #3500

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

sentrivana
Copy link
Contributor

use_scope and use_isolation_scope don't have POTel-friendly versions that work correctly with the OTel context yet. Adding them.

Copy link

codecov bot commented Sep 5, 2024

❌ 3778 Tests Failed:

Tests completed Failed Passed Skipped
16713 3778 12935 1916
View the top 3 failed tests by shortest run time
tests.integrations.celery.test_celery test_transaction_events[<lambda>1-error]
Stack Traces | 0s run time
No failure message available
tests.integrations.celery.test_update_celery_task_headers test_span_with_transaction
Stack Traces | 0s run time
No failure message available
tests.integrations.httpx.test_httpx test_option_trace_propagation_targets[httpx_client14-trace_propagation_targets14-https://example.com-True]
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana marked this pull request as ready for review September 5, 2024 11:32
@sentrivana sentrivana merged commit 2b10d78 into potel-base Sep 5, 2024
9 of 107 checks passed
@sentrivana sentrivana deleted the ivana/potel/use-scope branch September 5, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants