Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 3.6 compat #3517

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Remove 3.6 compat #3517

merged 3 commits into from
Sep 11, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 11, 2024 •
edited
Loading

Remove compat for Python < 3.7

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

❌ 3438 Tests Failed:

Tests completed Failed Passed Skipped
17053 3438 13615 1884
View the top 3 failed tests by shortest run time 
tests.integrations.celery.test_celery test_baggage_propagation
Stack Traces | 0s run time 
No failure message available

tests.integrations.celery.test_celery test_messaging_destination_name_nondefault_exchange
Stack Traces | 0s run time 
No failure message available

tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana marked this pull request as ready for review September 11, 2024 08:42
antonpirker
antonpirker approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its always a great feeling to delete code

@sentrivana sentrivana merged commit 28d8b82 into potel-base Sep 11, 2024
9 of 108 checks passed
@sentrivana sentrivana deleted the ivana/potel/drop-36-only-stuff branch September 11, 2024 09:27
@sentrivana sentrivana mentioned this pull request Sep 11, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

@szokeasaurusrex szokeasaurusrex Awaiting requested review from szokeasaurusrex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @antonpirker