Make DSC and trace_context work for outgoing traces #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add parsed baggage sentry items as items on the `sampling_context.trace_state` in `continue_trace` * Fix sampler to propagate the `trace_state` to children in both sampled and dropped cases * make `iter_headers` work * make `get_trace_context` work * add `dynamic_sampling_context` in `trace_context` so that it can be picked up by the client and added in the envelope header
❌ 2880 Tests Failed:
View the top 2 failed tests by shortest run time
View the full list of 1 ❄️ flaky tests
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
sl0thentr0py
changed the title
sentrivana
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sampling_context.trace_stateincontinue_tracetrace_stateto children in both sampled and dropped casesiter_headersworkget_trace_contextworkdynamic_sampling_contextintrace_contextso that it can be picked up by the client and added in the envelope headercloses #3478, #3565
Example trace using JS -> Python -> Rails
django headers
rails headers
dsc on envelope in django transaction
