Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http_methods_to_capture #3596

Merged
merged 6 commits into from
Oct 4, 2024

remove asgi tests, will add this to master

45ef6d0
Select commit
Loading
Failed to load commit list.
Merged

Fix http_methods_to_capture #3596

remove asgi tests, will add this to master
45ef6d0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 1s

35.56% (-38.43%) compared to 5ecd9c5

View this Pull Request on Codecov

35.56% (-38.43%) compared to 5ecd9c5

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 35.56%. Comparing base (5ecd9c5) to head (45ef6d0).

Files with missing lines Patch % Lines
sentry_sdk/integrations/asgi.py 62.50% 4 Missing and 2 partials ⚠️
sentry_sdk/integrations/wsgi.py 71.42% 2 Missing ⚠️
sentry_sdk/integrations/_wsgi_common.py 75.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5ecd9c5) and HEAD (45ef6d0). Click for more details.

HEAD has 186 uploads less than BASE
Flag BASE (5ecd9c5) HEAD (45ef6d0)
204 18
Additional details and impacted files
@@               Coverage Diff               @@
##           potel-base    #3596       +/-   ##
===============================================
- Coverage       73.99%   35.56%   -38.43%     
===============================================
  Files             136      136               
  Lines           13591    13596        +5     
  Branches         2698     2698               
===============================================
- Hits            10056     4836     -5220     
- Misses           2894     8287     +5393     
+ Partials          641      473      -168     
Files with missing lines Coverage Δ
sentry_sdk/integrations/_wsgi_common.py 49.58% <75.00%> (-33.32%) ⬇️
sentry_sdk/integrations/wsgi.py 79.20% <71.42%> (-16.00%) ⬇️
sentry_sdk/integrations/asgi.py 57.25% <62.50%> (-34.62%) ⬇️

... and 96 files with indirect coverage changes