Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database span op. #3628

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

antonpirker
Copy link
Member

Set the correct span op for database spans, instead of the generic "db".

@antonpirker antonpirker changed the base branch from master to potel-base October 8, 2024 12:07
Copy link

codecov bot commented Oct 8, 2024

❌ 40 Tests Failed:

Tests completed Failed Passed Skipped
110 40 70 0
View the top 3 failed tests by shortest run time
tests.integrations.aws_lambda.test_aws test_non_dict_event[python3.11-[]-False-1]
Stack Traces | 0.748s run time
.../integrations/aws_lambda/test_aws.py:522: in test_non_dict_event
    assert error_event["transaction"] == function_name
E   KeyError: 'transaction'
tests.integrations.aws_lambda.test_aws test_non_dict_event[python3.8-"Good dog!"-False-1]
Stack Traces | 0.748s run time
.../integrations/aws_lambda/test_aws.py:522: in test_non_dict_event
    assert error_event["transaction"] == function_name
E   KeyError: 'transaction'
tests.integrations.aws_lambda.test_aws test_non_dict_event[python3.12-\n            [\n                {"good dog": "Maisey"},\n                {"good dog": "Charlie"},\n                {"good dog": "Cory"},\n                {"good dog": "Bodhi"}\n            ]\n            -False-4]
Stack Traces | 0.766s run time
.../integrations/aws_lambda/test_aws.py:522: in test_non_dict_event
    assert error_event["transaction"] == function_name
E   KeyError: 'transaction'

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@antonpirker antonpirker self-assigned this Oct 8, 2024
@antonpirker antonpirker merged commit f0703b3 into potel-base Oct 8, 2024
3 of 7 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/fix-span-op branch October 8, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants