Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests using _span_recorder #3633

Merged

Conversation

antonpirker
Copy link
Member

Instead of getting span from ._span_recorder get it from envelope.

Copy link

codecov bot commented Oct 8, 2024

❌ 2930 Tests Failed:

Tests completed Failed Passed Skipped
17781 2930 14851 1727
View the top 3 failed tests by shortest run time
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_client_spans
Stack Traces | 0s run time
No failure message available
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time
No failure message available
tests.integrations.litestar.test_litestar test_middleware_partial_receive_send
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@antonpirker antonpirker merged commit f9187be into potel-base Oct 14, 2024
13 of 120 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/fix-tests-using-span-recorder branch October 14, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants