Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move subprocess breadcrumbs from maybe_create_breadcrumbs_from_span to integration. #3637

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Move subprocess breadcrumbs from maybe_create_breadcrumbs_from_span to integration. #3637

merged 8 commits into from
Oct 21, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Oct 9, 2024 •
edited
Loading

Move subprocess breadcrumbs from maybe_create_breadcrumbs_from_span into the stdlib integration and preserve the breadcrumb behavior in POTel.

@antonpirker antonpirker self-assigned this Oct 9, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

❌ 2582 Tests Failed:

Tests completed Failed Passed Skipped
20295 2582 17713 4412
View the top 3 failed tests by shortest run time 
tests.integrations.asgi.test_asgi test_capture_transaction_with_error
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_middleware_partial_receive_send
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_span_origin
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana mentioned this pull request Oct 10, 2024
Merged
@antonpirker antonpirker changed the title Fix breadcrumbs in POTel Move subprocess breadcrumbs from maybe_create_breadcrumbs_from_span to integration. Oct 21, 2024
@antonpirker antonpirker marked this pull request as ready for review October 21, 2024 09:18
sentrivana
sentrivana approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@antonpirker antonpirker merged commit 6e3778d into potel-base Oct 21, 2024
16 of 120 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/fix-breadcrumbs branch October 21, 2024 11:58
@antonpirker antonpirker mentioned this pull request Oct 21, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

@antonpirker antonpirker

Labels
Project: POTel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sentrivana