Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize span attrs properly #3668

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Serialize span attrs properly #3668

merged 6 commits into from
Oct 17, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Oct 17, 2024 •
edited
Loading

Add a util function for best-effort early serialization.

OTel is quite restrictive in what types it allows as span attributes.

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

❌ 2629 Tests Failed:

Tests completed Failed Passed Skipped
18528 2629 15899 4185
View the top 3 failed tests by shortest run time 
tests.integrations.litestar.test_litestar test_middleware_callback_spans
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_span_origin
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_span_origin
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana marked this pull request as ready for review October 17, 2024 14:57
@sentrivana sentrivana merged commit acf7746 into potel-base Oct 17, 2024
16 of 118 checks passed
@sentrivana sentrivana deleted the ivana/potel/serialize-early branch October 17, 2024 15:13
@sentrivana sentrivana mentioned this pull request Oct 17, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @sl0thentr0py