Fix breadcrumbs in HTTP clients #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 2513 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
sentrivana
approved these changes
Oct 23, 2024
| @@ -258,12 +264,23 @@ async def on_request_start(session, trace_config_ctx, params): | |||
| params.headers[key] = value | |||
|
|
|||
| trace_config_ctx.span = span | |||
| trace_config_ctx.span_data = data | |||
There was a problem hiding this comment.
Nit: maybe let's call it something like request_data instead of span_data since it's also used for breadcrumbs? (Also in the other integrations)
antonpirker
deleted the
antonpirker/potel/fix-breadcrumbs-in-http-clients
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the creation of breadcrumbs for outgoing HTTP requests from the
maybe_create_breadcrumbs_from_spaninto the integrations.